This mod is not the best, it generates too many messages due to the double message sent during the on_joinplayer event.
You could have simply overridden the function that sends the initial join/leave messages:
to directly modify the welcome message, instead of sending an extra one that unnecessarily clutters the chat.
The idea is good, but the code doesn't follow through. Also, there's no link to a GitHub repository or any other source, which is unfortunate, we can't submit issues or contribute to improving the code.
I’d also like to point out that this mod contains no translations, only Spanish. There’s not even English support, making it unusable for non-Spanish-speaking communities.
This mod is not the best, it generates too many messages due to the double message sent during the on_joinplayer event. You could have simply overridden the function that sends the initial join/leave messages:
to directly modify the welcome message, instead of sending an extra one that unnecessarily clutters the chat.
The idea is good, but the code doesn't follow through. Also, there's no link to a GitHub repository or any other source, which is unfortunate, we can't submit issues or contribute to improving the code.
Note: that there's already a mod that implements this idea: https://content.luanti.org/packages/Salzar/player_join/ Take a look (Code) when you have time.
I’d also like to point out that this mod contains no translations, only Spanish. There’s not even English support, making it unusable for non-Spanish-speaking communities.