Package: X Bows
hi i would like to get this mod reviewed
as reported to you on discord over a week ago, this mod is breaking other mods (that load after it) by writing to the global namespace. context: (https://github.com/mt-mods/pipeworks/issues/97) please fix this and resubmit for review
Hi wsor, this was already addressed in https://bitbucket.org/minetest_gamers/x_bows/commits/ddf690bcd304ea7e6c672060a809a164984462db on 2023-11-21, what else is expected from my side ?
regarding discord conversation there was another adjustment here: https://bitbucket.org/minetest_gamers/x_bows/commits/bb5815f4df6ea2cc2885a2202a02191cdb167c5c
the whole thing there is only for setting types for lua diagnostics and its not really needed for the functionality of the code, so will get rid of it
hi i would like to get this mod reviewed
as reported to you on discord over a week ago, this mod is breaking other mods (that load after it) by writing to the global namespace. context: (https://github.com/mt-mods/pipeworks/issues/97) please fix this and resubmit for review
Hi wsor, this was already addressed in https://bitbucket.org/minetest_gamers/x_bows/commits/ddf690bcd304ea7e6c672060a809a164984462db on 2023-11-21, what else is expected from my side ?
regarding discord conversation there was another adjustment here: https://bitbucket.org/minetest_gamers/x_bows/commits/bb5815f4df6ea2cc2885a2202a02191cdb167c5c
the whole thing there is only for setting types for lua diagnostics and its not really needed for the functionality of the code, so will get rid of it