The main problem is that splash_timer, underwater_timer, footstep_timer, first_entry, and entered_water are not per-player. This means that only one person will ever hear underwater sounds if multiple players are underwater (whoever is first in the minetest.get_connected_players() list), and several other similar issues.
The second "problem" (if you can call it that) is that... it really isn't "physics." I would expect a mod with this name to actually affect how water flows or interacts with things, not just adding some particles and sounds.
The third (very minor) problem is that it only applies to players, not other objects. For performance reasons, this makes sense, I guess, but still.
Thanks for your review. I will definatly work on the multiple people bug, and i have tried with the item in the water, but have not found it out so far. I will work on these bugs, thanks.
Alright, got that all updated for ya! The code should work for multiplayer, I wouldn't know because i dont play multi, but hopefully it works. If it is satisfactory, please reconsider your review :)
The main problem is that
splash_timer,underwater_timer,footstep_timer,first_entry, andentered_waterare not per-player. This means that only one person will ever hear underwater sounds if multiple players are underwater (whoever is first in theminetest.get_connected_players()list), and several other similar issues.The second "problem" (if you can call it that) is that... it really isn't "physics." I would expect a mod with this name to actually affect how water flows or interacts with things, not just adding some particles and sounds.
The third (very minor) problem is that it only applies to players, not other objects. For performance reasons, this makes sense, I guess, but still.
Thanks for your review. I will definatly work on the multiple people bug, and i have tried with the item in the water, but have not found it out so far. I will work on these bugs, thanks.
Alright, got that all updated for ya! The code should work for multiplayer, I wouldn't know because i dont play multi, but hopefully it works. If it is satisfactory, please reconsider your review :)
Okay, hold on for a bit. Im trying to find out how to update packages, but the latest release is out on my GitHub!
Alright! Update is out! Hopefully if fixes your issues.
converted review into a thread