The performance issue of the original made it somewhat unusable for me, the idea to turn the nodeboxes to meshes had been around for a while, glad to see someone actually doing it.
Btw. if you just use the nodegroup "leaves" that should cover it (i know it does for mcl* and mtg) and you won't need to do any string.find and probably don't need to exclude the plantlife stuff specifically either (yes the pine needles have group leaves as well: https://github.com/minetest/minetest_game/blob/master/mods/default/nodes.lua#L975 )
Btw. if you just use the nodegroup "leaves" that should cover it (i know it does for mcl* and mtg) and you won't need to do any string.find and probably don't need to exclude the plantlife stuff specifically either (yes the pine needles have group leaves as well: https://github.com/minetest/minetest_game/blob/master/mods/default/nodes.lua#L975 )
Unfortunately that limits the game support quite a bit. I just checked NodeCore and its leaves don't have that group. It's quite possible that other games that people may want to use this mod with don't have it either. Thus, string.find it is.
Unfortunately that limits the game support quite a bit. I just checked NodeCore and its leaves don't have that group. It's quite possible that other games that people may want to use this mod with don't have it either.
You could always report this issue back to NodeCore and other games so that they fix their compatibility, it will help your mod and others be compatible with them !
The performance issue of the original made it somewhat unusable for me, the idea to turn the nodeboxes to meshes had been around for a while, glad to see someone actually doing it.
Btw. if you just use the nodegroup "leaves" that should cover it (i know it does for mcl* and mtg) and you won't need to do any string.find and probably don't need to exclude the plantlife stuff specifically either (yes the pine needles have group leaves as well: https://github.com/minetest/minetest_game/blob/master/mods/default/nodes.lua#L975 )
Thanks for the review!
Unfortunately that limits the game support quite a bit. I just checked NodeCore and its leaves don't have that group. It's quite possible that other games that people may want to use this mod with don't have it either. Thus,
string.findit is.You could always report this issue back to NodeCore and other games so that they fix their compatibility, it will help your mod and others be compatible with them !