Other mods can't reliably depend on this bucket mod because it has the same name as MTG's bucket mod. Its easy to forget to enable it. Would it be possible to rename it (e.g. fluid_bucket), while optionally depending on bucket, and overriding the bucket functions and items? Then other mods that wish to utilize the changes made here can depend on the new name of mod without needing the player to remember enable this bucket mod.
I also posted this on the other instabreak mod, and got a reply from ROllerozxa saying that this basically overrides the groups of affected nodes, effectively removing any other group, and setting the group dig_immediate as the only group.
I recommend that while looping through the nodes, copy the original groups using table.copy then modify that copy to have dig_immediate. Then you override the item with that copy of the groups.
I recommend that while looping through the items, copy the original groups using table.copy then modify that copy to have dig_immediate. Then you override the item with that copy of the groups.
In the future I would like to revamp the whole process for smelting, likely in a separate mod. Adding a bloomery would be very good for that. Thank you for the review and suggestion!
It's been awhile since I've looked at this code. But will gladly accept feedback on it. If you do have any feedback, please comment on the PR here: https://github.com/ElCeejo/paleotest/pull/6
I have a PR that adds this feature. Haven't touched it in a while due to a lack of feedback. I needed some input on spawn rates and locations, but I did get it working.
Updated link to Calinou's Law: https://dev.luanti.org/calinous-law/
Other mods can't reliably depend on this bucket mod because it has the same name as MTG's bucket mod. Its easy to forget to enable it. Would it be possible to rename it (e.g. fluid_bucket), while optionally depending on bucket, and overriding the bucket functions and items? Then other mods that wish to utilize the changes made here can depend on the new name of mod without needing the player to remember enable this bucket mod.
I also posted this on the other instabreak mod, and got a reply from ROllerozxa saying that this basically overrides the groups of affected nodes, effectively removing any other group, and setting the group
dig_immediateas the only group.I recommend that while looping through the nodes, copy the original groups using
table.copythen modify that copy to havedig_immediate. Then you override the item with that copy of the groups.I recommend that while looping through the items, copy the original groups using
table.copythen modify that copy to havedig_immediate. Then you override the item with that copy of the groups.If I have this mod enabled with mods like sleeping_mat or grass_string, the recipes for the provided items are cleared.
If I have this mod enabled with mods like sleeping_mat or grass_string, the recipes for the provided items are cleared.
In the future I would like to revamp the whole process for smelting, likely in a separate mod. Adding a bloomery would be very good for that. Thank you for the review and suggestion!
This should be fixed by this merge request once it is merged: https://gitlab.com/echoes91/spears/-/merge_requests/5
This should be fixed by this merge request once it is merged: https://gitlab.com/echoes91/spears/-/merge_requests/5
I would highly recommend making use of the word "y'all" for when you want to use a plural "you".
Thats why it was meant to be an opt in setting to have them spawn in the normal world.
You can download it from here https://github.com/HeyITGuyFixIt/paleotest
It's been awhile since I've looked at this code. But will gladly accept feedback on it. If you do have any feedback, please comment on the PR here: https://github.com/ElCeejo/paleotest/pull/6
Yeah you can
looks like you accidentally converted it into a thread
I have a PR that adds this feature. Haven't touched it in a while due to a lack of feedback. I needed some input on spawn rates and locations, but I did get it working.
These are very high quality. I'm pretty sure there hasn't been any mobs this high quality before in Minetest. I highly recommend this.
Please re-review this. A lot of changes have been made.
I'll definitely look into rewriting it soon. I mostly wanted to release this to fix a bug I found in it. Thank you for your suggestions.